Skip to content

Merge .window.js/.worker.js/.any.js #11529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zcorpan opened this issue Jun 15, 2018 · 2 comments
Open

Merge .window.js/.worker.js/.any.js #11529

zcorpan opened this issue Jun 15, 2018 · 2 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Jun 15, 2018

I think it's a bit confusing how the three kinds of tests are subtly different, and I imagine that new contributors can be similarly confused.

I have two ideas for possible improvement:

  • Use only .any.js and update the tests accordingly.
  • Still use the 3 filename conventions, but make it more consistent how to write each kind of test (e.g. include GLOBAL in .window.js and .worker.js).

The first would simplify the implementation, the second could be slightly more convenient for test authors.

@annevk
Copy link
Member

annevk commented Aug 7, 2018

I kinda like window.js. It seems silly that worker.js currently requires importScripts("/resources/testharness.js"); at the top though.

@inexorabletash
Copy link
Contributor

worker.js also requires a done(); at the end.

(Came here to file a bug proposing that we fix worker.js and update the tests.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@gsnedders @zcorpan @foolip @inexorabletash @Hexcles @annevk and others